From 83b4206b15bb92f45460ae7eabdc83dfe8865fa9 Mon Sep 17 00:00:00 2001 From: wdvxdr Date: Tue, 28 Sep 2021 15:51:35 +0800 Subject: [PATCH] fix: wrong sha1 cmp reported by staticcheck. --- internal/btree/btree_test.go | 1 + internal/btree/helper.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/btree/btree_test.go b/internal/btree/btree_test.go index 9de67b0..ab43949 100644 --- a/internal/btree/btree_test.go +++ b/internal/btree/btree_test.go @@ -44,6 +44,7 @@ func TestBtree(t *testing.T) { assert2.NoError(t, bt.Close()) bt, err = Open(f) + assert2.NoError(t, err) for i, tt := range tests { assert2.Equal(t, []byte(tt), bt.Get(sha[i])) } diff --git a/internal/btree/helper.go b/internal/btree/helper.go index cbff971..ad172d9 100644 --- a/internal/btree/helper.go +++ b/internal/btree/helper.go @@ -32,7 +32,7 @@ func cmp(a, b *byte) int64 { if *(*uint64)(pa) != *(*uint64)(pb) { return int64(*(*uint64)(pa) - *(*uint64)(pb)) } - return int64(*(*uint32)(unsafe.Add(pa, 8)) - *(*uint32)(unsafe.Add(pa, 8))) + return int64(*(*uint32)(unsafe.Add(pa, 8)) - *(*uint32)(unsafe.Add(pb, 8))) } func copysha1(dst *byte, src *byte) {