drop(pool): unnecessay nil judge

binary/pool.go

@@ -16,11 +16,10 @@ var bufferPool = sync.Pool{
 
 // SelectWriter 从池中取出一个 Writer
 func SelectWriter() *Writer {
-	w := bufferPool.Get().(*Writer)
+	// 因为 bufferPool 定义有 New 函数
-	if w == nil {
+	// 所以 bufferPool.Get() 永不为 nil
-		return new(Writer)
+	// 不用判空
-	}
+	return bufferPool.Get().(*Writer)
-	return w
 }
 
 // PutWriter 将 Writer 放回池中
@@ -103,9 +102,9 @@ var b256kPool = sync.Pool{
 // Get256KBytes 获取一个128k大小 []byte
 func Get256KBytes() *[]byte {
 	buf := b256kPool.Get().(*[]byte)
-	if buf == nil {
+	// 因为 b256kPool 定义有 New 函数
-		return make128kSlicePointer()
+	// 所以 b256kPool.Get() 永不为 nil
-	}
+	// 不用判空
 	if cap(*buf) < size256k {
 		return make128kSlicePointer()
 	}

binary/writer.go

@@ -69,9 +69,7 @@ func (w *Writer) WriteBool(b bool) {
 }
 
 func (w *Writer) EncryptAndWrite(key []byte, data []byte) {
-	tea := NewTeaCipher(key)
+	w.Write(NewTeaCipher(key).Encrypt(data))
-	ed := tea.Encrypt(data)
-	w.Write(ed)
 }
 
 func (w *Writer) WriteIntLvPacket(offset int, f func(writer *Writer)) {